Skip to content

Multi fetch needs the array of keys splatted.#29

Merged
beauby merged 2 commits into
jsonapi-rb:masterfrom
RealSavvy:splat-for-multi-fetch
Nov 17, 2017
Merged

Multi fetch needs the array of keys splatted.#29
beauby merged 2 commits into
jsonapi-rb:masterfrom
RealSavvy:splat-for-multi-fetch

Conversation

@rovermicrover

Copy link
Copy Markdown
Contributor

In reference to this other PR #28

@beauby

beauby commented Nov 17, 2017

Copy link
Copy Markdown
Member

Thanks for the PR 👍. You'll probably need to add a splat there as well for the tests to pass.

LGTM otherwise.

@rovermicrover

Copy link
Copy Markdown
Contributor Author

Well aren't I stupid/lazy. I fixed that on the last PR and completely forgot about it my bad.

@beauby

beauby commented Nov 17, 2017

Copy link
Copy Markdown
Member

Perfect, thanks! Merging

@beauby beauby merged commit f154799 into jsonapi-rb:master Nov 17, 2017
@samnang

samnang commented Dec 21, 2017

Copy link
Copy Markdown

@beauby any chance to get a new release that contains this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants